Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: security: add an option to disable the remote module (backport: 4-0-x) #15222

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 17, 2018

Backport of #13028

See that PR for details.

undefined

Notes: Added webPreferences.enableRemoteModule option allowing to disable the remote module to increase sandbox security.

@trop trop bot requested review from a team October 17, 2018 18:34
@trop trop bot added the backport This is a backport PR label Oct 17, 2018
@alexeykuzmin
Copy link
Contributor

alexeykuzmin commented Oct 17, 2018

This PR requires an explicit approval from the team to be merged since it brings in a new feature to a beta release line.
Please remove the wip label only when it's approved.

@codebytere
Copy link
Member

(approved pending group approval at next kickoff)

Copy link
Contributor

@groundwater groundwater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by unanimous vote!

@alexeykuzmin alexeykuzmin changed the title feat: security: add an option to disable the remote module (backport: 4-0-x) [wip] feat: security: add an option to disable the remote module (backport: 4-0-x) Oct 22, 2018
@alexeykuzmin alexeykuzmin changed the title [wip] feat: security: add an option to disable the remote module (backport: 4-0-x) feat: security: add an option to disable the remote module (backport: 4-0-x) Oct 22, 2018
@alexeykuzmin alexeykuzmin merged commit a313aae into electron:4-0-x Oct 23, 2018
@release-clerk
Copy link

release-clerk bot commented Oct 23, 2018

Release Notes Persisted

Added webPreferences.enableRemoteModule option allowing to disable the remote module to increase sandbox security.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants