refactor: remove api::WebContents::CreateFrom #15241
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Currently the
WebContents::CreateFrom
method can have 3 different kinds of behaviors depending on different conditions, and it is impossible to know which path it would go by simply looking at the code.This PR separates it to 3 methods with different names, and makes the behavior explicit by name.
As a side effect we can avoid creating V8 wrapper for
WebContents
in some cases when theWebContents
is not accessed from JS.This PR should not have any behavior change on existing code.
Checklist
npm test
passesRelease Notes
Notes: Remove
api::WebContents::CreateFrom
.