From 61bbed5ad0a8167eb6cdc45eea3a2742d099092b Mon Sep 17 00:00:00 2001 From: Milan Burda Date: Wed, 24 Oct 2018 07:34:15 +0200 Subject: [PATCH 1/3] chore: bump minimum supported macOS version to 10.10 --- atom/browser/resources/mac/Info.plist | 2 +- atom/common/node_includes.h | 2 +- docs/api/frameless-window.md | 9 ++++----- docs/tutorial/development-environment.md | 2 +- docs/tutorial/support.md | 4 ++-- 5 files changed, 9 insertions(+), 10 deletions(-) diff --git a/atom/browser/resources/mac/Info.plist b/atom/browser/resources/mac/Info.plist index 9094f0f7335ed..97b6d9c65dbc7 100644 --- a/atom/browser/resources/mac/Info.plist +++ b/atom/browser/resources/mac/Info.plist @@ -23,7 +23,7 @@ LSApplicationCategoryType public.app-category.developer-tools LSMinimumSystemVersion - 10.9.0 + 10.10.0 NSMainNibFile MainMenu NSPrincipalClass diff --git a/atom/common/node_includes.h b/atom/common/node_includes.h index 8067bf4a959fc..9e440442b2b46 100644 --- a/atom/common/node_includes.h +++ b/atom/common/node_includes.h @@ -30,7 +30,7 @@ #undef NO_RETURN #undef LIKELY #undef arraysize -#undef debug_string // This is defined in macOS 10.9 SDK in AssertMacros.h. +#undef debug_string // This is defined in macOS SDK in AssertMacros.h. #include "env-inl.h" #include "env.h" #include "node.h" diff --git a/docs/api/frameless-window.md b/docs/api/frameless-window.md index 596e35dc3266c..45421ef9a43e8 100644 --- a/docs/api/frameless-window.md +++ b/docs/api/frameless-window.md @@ -21,11 +21,10 @@ win.show() ### Alternatives on macOS -On macOS 10.9 Mavericks and newer, there's an alternative way to specify -a chromeless window. Instead of setting `frame` to `false` which disables -both the titlebar and window controls, you may want to have the title bar -hidden and your content extend to the full window size, yet still preserve -the window controls ("traffic lights") for standard window actions. +There's an alternative way to specify a chromeless window. +Instead of setting `frame` to `false` which disables both the titlebar and window controls, +you may want to have the title bar hidden and your content extend to the full window size, +yet still preserve the window controls ("traffic lights") for standard window actions. You can do so by specifying the `titleBarStyle` option: #### `hidden` diff --git a/docs/tutorial/development-environment.md b/docs/tutorial/development-environment.md index 3a5b956208e53..9dc444435719e 100644 --- a/docs/tutorial/development-environment.md +++ b/docs/tutorial/development-environment.md @@ -7,7 +7,7 @@ rudimentary understanding of your operating system's command line client. ## Setting up macOS -> Electron supports Mac OS X 10.9 (and all versions named macOS) and up. Apple +> Electron supports macOS 10.10 (OS X Yosemite) and up. Apple does not allow running macOS in virtual machines unless the host computer is already an Apple computer, so if you find yourself in need of a Mac, consider using a cloud service that rents access to Macs (like [MacInCloud][macincloud] diff --git a/docs/tutorial/support.md b/docs/tutorial/support.md index bdb3b8678485f..89c172eecbcd2 100644 --- a/docs/tutorial/support.md +++ b/docs/tutorial/support.md @@ -61,7 +61,7 @@ Following platforms are supported by Electron: ### macOS Only 64bit binaries are provided for macOS, and the minimum macOS version -supported is macOS 10.9. +supported is macOS 10.10 (OS X Yosemite). ### Windows @@ -79,7 +79,7 @@ Ubuntu 12.04, the `armv7l` binary is built against ARM v7 with hard-float ABI an NEON for Debian Wheezy. [Until the release of Electron 2.0][arm-breaking-change], Electron will also -continue to release the `armv7l` binary with a simple `arm` suffix. Both binaries +continue to release the `armv7l` binary with a simple `arm` suffix. Both binaries are identical. Whether the prebuilt binary can run on a distribution depends on whether the From feaa55e2e31f435c82569d8a12ccb3dd15cd1ce7 Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Wed, 24 Oct 2018 20:14:05 +0200 Subject: [PATCH 2/3] OS X Yosemite -> Yosemite Co-Authored-By: miniak --- docs/tutorial/support.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tutorial/support.md b/docs/tutorial/support.md index 89c172eecbcd2..c2fb91963fdcd 100644 --- a/docs/tutorial/support.md +++ b/docs/tutorial/support.md @@ -61,7 +61,7 @@ Following platforms are supported by Electron: ### macOS Only 64bit binaries are provided for macOS, and the minimum macOS version -supported is macOS 10.10 (OS X Yosemite). +supported is macOS 10.10 (Yosemite). ### Windows From 396d602653ce6943d28662b7c1604e31e45f1496 Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Wed, 24 Oct 2018 20:14:15 +0200 Subject: [PATCH 3/3] OS X Yosemite -> Yosemite Co-Authored-By: miniak --- docs/tutorial/development-environment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tutorial/development-environment.md b/docs/tutorial/development-environment.md index 9dc444435719e..b99a0ff20e3b6 100644 --- a/docs/tutorial/development-environment.md +++ b/docs/tutorial/development-environment.md @@ -7,7 +7,7 @@ rudimentary understanding of your operating system's command line client. ## Setting up macOS -> Electron supports macOS 10.10 (OS X Yosemite) and up. Apple +> Electron supports macOS 10.10 (Yosemite) and up. Apple does not allow running macOS in virtual machines unless the host computer is already an Apple computer, so if you find yourself in need of a Mac, consider using a cloud service that rents access to Macs (like [MacInCloud][macincloud]