New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: match Chrome's font fallback behavior #15486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
force-pushed
the
font-defaults
branch
from
October 31, 2018 00:24
de1cebb
to
549357e
Compare
I measured the performance of the |
nornagon
force-pushed
the
font-defaults
branch
from
November 2, 2018 23:59
549357e
to
b1089dc
Compare
nornagon
changed the title
[wip] fix: match Chrome's font fallback behavior
fix: match Chrome's font fallback behavior
Nov 6, 2018
nornagon
force-pushed
the
font-defaults
branch
from
November 6, 2018 21:31
4e2d749
to
5c8187f
Compare
jkleinsc
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
codebytere
approved these changes
Nov 8, 2018
Release Notes Persisted
|
3 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up blink's default fonts (
serif
,sans-serif
, etc.) to match Chrome's behavior, which includes per-script fallbacks.Fixes #15481.
TODO:
Evaluate the possibility of directly usingIts use offont_family_cache.cc
from Chrome.Profile
doesn't match the needs of Electron.Evaluate the possibility of splitting outThis would be difficult currently, these defaults are embedded pretty deep into Chromium's preference system and it'd be a challenge to refactor them to a common place in a way that would make sense to upstream to Chromium. The lists change quite infrequently though: the last change was in 2016, so I think it's OK to copy/paste them.kFontDefaults
in upstream Chromium (defined here) so we can include them without patching.Checklist
npm test
passesRelease Notes
Notes: fixed default font fallback for non-latin scripts