Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect high contrast color mode #15493

Merged
merged 3 commits into from Oct 31, 2018
Merged

feat: detect high contrast color mode #15493

merged 3 commits into from Oct 31, 2018

Conversation

brenca
Copy link
Contributor

@brenca brenca commented Oct 31, 2018

Description of Change

Implements #13178's request. The gist of the issue is already well described there, but a tldr:
We currently can detect inverted color schemes (light text, dark background), and those are a subset of high contrast color schemes, but we can't detect the rest of the high contrast schemes. With this new method and event, this is resolved.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: added event and method to detect high contrast color schemes

@brenca brenca requested review from MarshallOfSound and a team October 31, 2018 09:55
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkleinsc jkleinsc merged commit 6d2a088 into master Oct 31, 2018
@release-clerk
Copy link

release-clerk bot commented Oct 31, 2018

Release Notes Persisted

added event and method to detect high contrast color schemes

@Logerfo
Copy link

Logerfo commented Jan 10, 2019

What if the user has a custom theme installed in windows? A theme which changes the system colors to make a dark theme. Example: penumbra. There will be no indicator to the application building in an electron framework. Would it be possible for electron to expose the Windows system colors (if the running OS is Windows, of course)? If this is already available, I couldn't find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants