New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly display zoom in accelerator on mac #15502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This is sad =/ |
@alexeykuzmin yeah that's why i marked it WIP sadly |
@codebytere Let's merge this PR since it fixes the menu issue, |
Release Notes Persisted
|
I was unable to backport this PR to "4-0-x" cleanly; |
Description of Change
Resolves #15496.
Backports this CL from Chromium to fix
Cmd+Plus
to zoom keyboard shortcut. Tested to fix the display, but there is some weirdness around still needingShift
to trigger the correct zoom behavior.Ideally, i think we should enable both
Cmd+Plus
andShift+Cmd+Plus
to zoom on MacOS, as this most closely mirrors corresponding behavior on Chrome itself./cc @brenca @alexeykuzmin @MarshallOfSound
Checklist
npm test
passesRelease Notes
Notes: fix incorrect display of 'zoom in' accelerator on mac