Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly display zoom in accelerator on mac #15502

Merged
merged 3 commits into from Nov 7, 2018
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Oct 31, 2018

Description of Change

Resolves #15496.

Backports this CL from Chromium to fix Cmd+Plus to zoom keyboard shortcut. Tested to fix the display, but there is some weirdness around still needing Shift to trigger the correct zoom behavior.

Ideally, i think we should enable both Cmd+Plus and Shift+Cmd+Plus to zoom on MacOS, as this most closely mirrors corresponding behavior on Chrome itself.

/cc @brenca @alexeykuzmin @MarshallOfSound

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: fix incorrect display of 'zoom in' accelerator on mac

@codebytere codebytere requested a review from a team October 31, 2018 16:15
@codebytere codebytere changed the title fix: correctly display zoom in accelerator on mac [WIP] fix: correctly display zoom in accelerator on mac Oct 31, 2018
Copy link
Contributor

@brenca brenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexeykuzmin
Copy link
Contributor

Tested to fix the display, but there is some weirdness around still needing Shift to trigger the correct zoom behavior.

This is sad =/

@codebytere
Copy link
Member Author

codebytere commented Nov 1, 2018

@alexeykuzmin yeah that's why i marked it WIP sadly

@alexeykuzmin
Copy link
Contributor

@codebytere Let's merge this PR since it fixes the menu issue,
And create a new PR for the shortcut issue.

@codebytere codebytere changed the title [WIP] fix: correctly display zoom in accelerator on mac fix: correctly display zoom in accelerator on mac Nov 7, 2018
@codebytere codebytere merged commit 833269f into master Nov 7, 2018
@release-clerk
Copy link

release-clerk bot commented Nov 7, 2018

Release Notes Persisted

fix incorrect display of 'zoom in' accelerator on mac

@trop
Copy link
Contributor

trop bot commented Nov 7, 2018

I was unable to backport this PR to "4-0-x" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Zoom In" shortcut doesn't work
4 participants