Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: es6ify 'Breaking Changes' and 'File' API pages #15507

Merged
merged 3 commits into from Dec 5, 2018

Conversation

ntocampos
Copy link

@ntocampos ntocampos commented Oct 31, 2018

Description of Change

This pull-request "es6ifies" code snippets in the Breaking Changes and File object documentation pages, as suggested on #14842.
cc @ckerr

Checklist

  • PR description included and stakeholders cc'd
  • relevant documentation is changed
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@ntocampos ntocampos requested a review from a team October 31, 2018 22:30
@welcome
Copy link

welcome bot commented Oct 31, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@MarshallOfSound
Copy link
Member

@ntocampos Can you group all your ES6'ify PR's into one PR please? It'll make it easier to review in one go and will cause less CI jobs to run 👍

@ntocampos
Copy link
Author

@ntocampos Can you group all your ES6'ify PR's into one PR please? It'll make it easier to review in one go and will cause less CI jobs to run 👍

Sure. I'm gonna do this now 😄

@ntocampos ntocampos changed the title docs: es6ify 'Breaking Changes' API page docs: es6ify 'Breaking Changes' and 'File' API pages Oct 31, 2018
@ntocampos
Copy link
Author

Done. I've closed the other PR.

@MarshallOfSound MarshallOfSound merged commit cfbea4a into electron:master Dec 5, 2018
@release-clerk
Copy link

release-clerk bot commented Dec 5, 2018

Release Notes Persisted

no-notes

@welcome
Copy link

welcome bot commented Dec 5, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@jatin33
Copy link

jatin33 commented Oct 16, 2019

Can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants