Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hiddenInset titleBar console spam #15576

Merged
merged 1 commit into from Nov 6, 2018
Merged

fix: hiddenInset titleBar console spam #15576

merged 1 commit into from Nov 6, 2018

Conversation

codebytere
Copy link
Member

Description of Change

Set [window setTitlebarAppearsTransparent:YES]; for hiddenInset. Should fix some of the remaining console spam users see:

2018-10-02 12:06:59.730 Electron[34332:825632] *** WARNING: Textured window <AtomNSWindow: 0x7fa08cd74cb0> is getting an implicitly transparent titlebar. This will break when linking against newer SDKs. Use NSWindow's -titlebarAppearsTransparent=YES instead.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: fix: hiddenInset titleBar console spam

@codebytere codebytere requested a review from a team November 5, 2018 21:10
@codebytere codebytere changed the title fix: hiddenInset titleBar console spam fix: hiddenInset titleBar console spam Nov 6, 2018
@codebytere codebytere changed the title fix: hiddenInset titleBar console spam fix: hiddenInset titleBar console spam Nov 6, 2018
@codebytere codebytere merged commit ece4c81 into master Nov 6, 2018
@release-clerk
Copy link

release-clerk bot commented Nov 6, 2018

Release Notes Persisted

fix: hiddenInset titleBar console spam

@codebytere codebytere deleted the fix-window-error branch November 6, 2018 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants