fix: make certain values on process read-only
#15628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `mas` * `windowsStore` * `versions.electron` * `versions.chrome` * `type` * `pid` * `sandboxed`
nornagon
approved these changes
Nov 7, 2018
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Certain values on the
processobject should be read-only, either to match similar values (e.g.process.versions.x) or because it doesn't make sense for the values to be changed (because they represent some condition that cannot be changed).Part of this change was slated for v2.0, but the change was not made in that version.
The values that I've made read-only are:
process.masprocess.windowsStoreprocess.versions.electronprocess.versions.chromeprocess.typeprocess.pidprocess.sandboxedI'm fairly certain there's no good reason for any of these values to not be read-only, but please comment if I've missed something.
Fixes #8083
Checklist
npm testpassesRelease Notes
Notes: fix: make certain values on
processread-only