diff --git a/atom/common/api/atom_bindings.cc b/atom/common/api/atom_bindings.cc index 42eae9653aa7d..991cbd96943be 100644 --- a/atom/common/api/atom_bindings.cc +++ b/atom/common/api/atom_bindings.cc @@ -72,19 +72,18 @@ void AtomBindings::BindTo(v8::Isolate* isolate, v8::Local process) { base::Unretained(this))); #if defined(MAS_BUILD) - dict.Set("mas", true); + dict.SetReadOnly("mas", true); #endif #if defined(OS_WIN) if (IsRunningInDesktopBridge()) - dict.Set("windowsStore", true); + dict.SetReadOnly("windowsStore", true); #endif mate::Dictionary versions; if (dict.Get("versions", &versions)) { - // TODO(kevinsawicki): Make read-only in 2.0 to match node - versions.Set(ATOM_PROJECT_NAME, ATOM_VERSION_STRING); - versions.Set("chrome", CHROME_VERSION_STRING); + versions.SetReadOnly(ATOM_PROJECT_NAME, ATOM_VERSION_STRING); + versions.SetReadOnly("chrome", CHROME_VERSION_STRING); } } diff --git a/atom/common/node_bindings.cc b/atom/common/node_bindings.cc index f08ed8bdcc54f..a9ff32766a961 100644 --- a/atom/common/node_bindings.cc +++ b/atom/common/node_bindings.cc @@ -339,7 +339,7 @@ node::Environment* NodeBindings::CreateEnvironment( } mate::Dictionary process(context->GetIsolate(), env->process_object()); - process.Set("type", process_type); + process.SetReadOnly("type", process_type); process.Set("resourcesPath", resources_path); // Do not set DOM globals for renderer process. if (browser_env_ != BROWSER) diff --git a/atom/renderer/atom_sandboxed_renderer_client.cc b/atom/renderer/atom_sandboxed_renderer_client.cc index db05f967188c5..fb6ec0a0ac40c 100644 --- a/atom/renderer/atom_sandboxed_renderer_client.cc +++ b/atom/renderer/atom_sandboxed_renderer_client.cc @@ -158,18 +158,18 @@ void AtomSandboxedRendererClient::InitializeBindings( process.Set("argv", base::CommandLine::ForCurrentProcess()->argv()); process.Set("execPath", GetExecPath()); - process.Set("pid", base::GetCurrentProcId()); + process.SetReadOnly("pid", base::GetCurrentProcId()); process.Set("resourcesPath", NodeBindings::GetHelperResourcesPath()); - process.Set("sandboxed", true); - process.Set("type", "renderer"); + process.SetReadOnly("sandboxed", true); + process.SetReadOnly("type", "renderer"); #if defined(MAS_BUILD) - process.Set("mas", true); + process.SetReadOnly("mas", true); #endif #if defined(OS_WIN) if (IsRunningInDesktopBridge()) - process.Set("windowsStore", true); + process.SetReadOnly("windowsStore", true); #endif // Pass in CLI flags needed to setup the renderer diff --git a/docs/api/process.md b/docs/api/process.md index 12c06b69b3d7f..5b042c5783ece 100644 --- a/docs/api/process.md +++ b/docs/api/process.md @@ -103,7 +103,7 @@ A `Boolean` that controls whether or not process warnings printed to `stderr` in ### `process.type` -A `String` representing the current process's type, can be `"browser"` (i.e. main process) or `"renderer"`. +A `String` representing the current process's type, can be `"browser"` (i.e. main process), `"renderer"`, or `"worker"` (i.e. web worker). ### `process.versions.chrome`