New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable v2 sandbox on mac #15647
Conversation
marking as WIP because this has exposed some failures on linux and some tests that expect the |
ah dangit i didn't intend to approve this yet, ignore the above 🤦♀️ |
Rebased on top of #15894 |
Upstream is trying to remove the |
Pretty sure I can update & land this before 72. Thanks for the info. |
dfc2db0
to
a0d485e
Compare
I believe the mac and arm failures are flakes, see #16027 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release Notes Persisted
|
Description of Change
This re-enables the v2 sandbox on mac (disabled by 878c5b6). That commit asserts that the v2 sandbox would prevent the
mixed-sandbox
mode from working, but in my testing with this change, it seems to work fine.Checklist
npm test
passesRelease Notes
Notes: