Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow partial setting of window bounds #15677

Merged
merged 3 commits into from Nov 12, 2018
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Nov 11, 2018

Description of Change

This PR extends the existing win.setBounds functionality by allowing developers to partially update bounds without being forced to pass in all four bounds values. No existing functionality is altered.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: allow partial setting of window bounds with win.setBounds()

@codebytere codebytere requested review from a team November 11, 2018 18:13
@codebytere codebytere added enhancement ✨ semver/minor backwards-compatible functionality target/4-0-x labels Nov 11, 2018
Copy link
Contributor

@alexeykuzmin alexeykuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/browser/api/browser-window.js Outdated Show resolved Hide resolved
spec/api-browser-window-spec.js Outdated Show resolved Hide resolved
spec/api-browser-window-spec.js Outdated Show resolved Hide resolved
Copy link
Contributor

@alexeykuzmin alexeykuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Co-Authored-By: codebytere <codebytere@github.com>
@codebytere codebytere merged commit c06f023 into master Nov 12, 2018
@release-clerk
Copy link

release-clerk bot commented Nov 12, 2018

Release Notes Persisted

allow partial setting of window bounds with win.setBounds()

@trop
Copy link
Contributor

trop bot commented Nov 12, 2018

I have automatically backported this PR to "4-0-x", please check out #15687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants