feat: add numpad keyboard mappings #15689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
changed the title
codebytere
force-pushed
the
numpad-mappings
branch
from
59b2f17
to
6181794
Compare
codebytere
changed the title
nitsakh
suggested changes
Nov 13, 2018
codebytere
force-pushed
the
numpad-mappings
branch
from
bf74629
to
83a526b
Compare
ckerr
approved these changes
Nov 14, 2018
nitsakh
approved these changes
Nov 14, 2018
|
Release Notes Persisted
|
neo291
pushed a commit
to neo291/electron
that referenced
this pull request
Nov 16, 2018
neo291
pushed a commit
to neo291/electron
that referenced
this pull request
Nov 16, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs: #11310.
Adds numpad mappings to our keyboard shortcuts list to allow for their use in accelerators.
/cc @brenca
Checklist
npm testpassesRelease Notes
Notes: Allow numpad keys to be used as accelerators.