fix: crash in sandbox on linux when getting execPath

[nornagon]

calling base::PathService::Get(base::FILE_EXE, &path) on linux crashes with --enable-sandbox:

#0  0x00007faabaa2ae97 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007faabaa2c801 in __GI_abort () at abort.c:79
#2  0x000056153ea42085 in  () at ./../../base/debug/debugger_posix.cc:258
#3  0x000056153e97e5be in ~LogMessage() () at ./../../base/logging.cc:858
#4  0x000056153ea55ac4 in PathProviderPosix() () at ./../../base/base_paths_posix.cc:43
#5  0x000056153e9b11ed in Get() () at ./../../base/path_service.cc:207
#6  0x000056153e90857c in GetExecPath () at ../../electron/atom/renderer/atom_sandboxed_renderer_client.cc:85
#7  0x000056153e90857c in InitializeBindings() () at ../../electron/atom/renderer/atom_sandboxed_renderer_client.cc:160
#8  0x000056153e9093f5 in DidCreateScriptContext() () at ../../electron/atom/renderer/atom_sandboxed_renderer_client.cc:219
#9  0x000056153e906607 in DidCreateScriptContext() () at ../../electron/atom/renderer/atom_render_frame_observer.cc:96
#10 0x0000561542469ae5 in DidCreateScriptContext() () at ./../../content/renderer/render_frame_impl.cc:5150

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation is changed or added
• PR title follows semantic commit guidelines

Release Notes

Notes:

• fix a crash on Linux when starting a sandboxed renderer
• the resourcesPath property is no longer available on process in sandboxed renderers

[nornagon]

Hmm, looks like execPath is used for determining whether security warnings should be logged. We could probably find a different way to do that.

@miniak could you explain why execPath was changed in #13839?

[miniak]

@nornagon, I don’t remember exactly, I should probably just have used process.helperExecPath in the first place

[nornagon]

@miniak it's still unclear to me what #13839 was fixing, and additionally unclear why you would ever want the path to Electron Helper rather than to Electron.

[nornagon]

I'm also still uncertain about removing resourcesPath. Can anyone say for sure whether that will/won't break something important?

[miniak]

@nornagon resourcesPath was added just for consistency. We don’t use it. But somebody else might.

[nornagon]

Merging this without review from @electron/docs because the change to docs is trivial.

I'm removing resourcesPath because I'm not sure that a sandboxed renderer could actually do anything useful with that path, what with being sandboxed and all. Happy to restore it if someone comes up with a use case though!

[release-clerk]

Release Notes Persisted

• fix a crash on Linux when starting a sandboxed renderer

• the resourcesPath property is no longer available on process in sandboxed renderers