feat: promisify app.getFileIcon()

[codebytere]

Description of Change

Promisifies app.getFileIcon natively.

Todo:

• specs
• docs

/cc @ckerr @deepak1556

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation is changed or added
• PR title follows semantic commit guidelines

Release Notes

Notes: Promisifies app.getFileIcon

Co-authored-by: Charles Kerr ckerr@github.com

[ckerr]

The pieces that are here LGTM. Nice work!

Before we start merging PRs though I think we need a plan to make the API churn more managable to Electron app developers, e.g. the framework discussed at https://github.com/electron/maintainers/issues/159 (CC @alexeykuzmin, @MarshallOfSound).

Additionally, whatever plan we follow should be in a public repo. E.g. if we still like 159 we should move it verbatim into electron/electron/issues

Marking as Request changes to press pause while getting feedback from pineapples on how we want this rollout to proceed not due to any code issues in the PR.

[codebytere]

Some thoughts:

The initial plan for promisification hinged on waiting until Node 8 (which bundled util.promisify) and then blanket converting all methods taking callbacks at once. From discussion in that issue, i think (and i agree with this perspective) that native promisification as a goal is more desirable than util.promisify, as it provides less of a band-aid over the issue and addresses it at the root.

However, this means that we can't, then, batch convert over all relevant methods at once, and need to do it in this more piecemeal manner. My proposal would be that we maintain a public project board with our progress on this issue, in addition to an issue in maintainers, and merge these piecemeal rather than bottleneck on each method being converted so that we can flag them all at once.

What are y'all's thoughts?

^convo continued in another issue

[codebytere]

dangit meant to comment not close and comment

[deepak1556]

LGTM with minor change. Thanks!

[release-clerk]

Release Notes Persisted

Promisifies app.getFileIcon