Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: eliminate duplicate code exposing process APIs #15824

Merged
merged 1 commit into from Nov 28, 2018
Merged

refactor: eliminate duplicate code exposing process APIs #15824

merged 1 commit into from Nov 28, 2018

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Nov 24, 2018 •
edited

Description of Change

  • Eliminate duplicate code exposing process APIs (sandboxed vs non-sandboxed renderer).
  • Expose missing process.getCreationTime() in sandboxed renderers.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: Missing process.getCreationTime() exposed in sandboxed renderers.

@miniak miniak force-pushed the miniak/process branch 3 times, most recently from 811701d to 5faa873 Compare November 26, 2018 15:48
@miniak miniak self-assigned this Nov 26, 2018
nornagon
nornagon approved these changes Nov 26, 2018
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please add a comment!

atom/common/api/atom_bindings.cc Show resolved Hide resolved
@codebytere codebytere merged commit 07f8f5f into master Nov 28, 2018
@release-clerk
Copy link

release-clerk bot commented Nov 28, 2018

Release Notes Persisted

Missing process.getCreationTime() exposed in sandboxed renderers.

@codebytere codebytere deleted the miniak/process branch November 28, 2018 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

@ppontes ppontes ppontes approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

@alexeykuzmin alexeykuzmin Awaiting requested review from alexeykuzmin

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miniak @nornagon @zcbenz @codebytere @ppontes