New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get foreground color from GtkMenubar#menubar #15878
Conversation
Use menubar item color (not menu item color). Closes electron#15194
Looks good to me as it stands, although ill wait for a few more linux people to give it some eyes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix!
Tested with themes CobiBird, Adwaita and Adwaita Dark. Seems to work fine. |
Release Notes Persisted
|
@inukshuk can you open manual backports? |
I was unable to backport this PR to "4-0-x" cleanly; |
I was unable to backport this PR to "3-1-x" cleanly; |
I was unable to backport this PR to "3-0-x" cleanly; |
@codebytere I'd be happy to. Does that mean opening separate PRs in the |
@codebytere Should this be backported to 2-0-x as well, or just starting with 3-0-x? Asking because you backported the menubar background color thingy to 2-0-x but this PR only got tagged beginning with 3-0-x |
Description of Change
Resolves #15194
This pulls the GTK menubar item's color from the theme's menubar item foreground. Previously, the menu item's color was used, which could cause issues with some themes (e.g., see the screenshot below using the Yaru theme, which is default in the latest version of Ubuntu):
cc @codebytere
Checklist
npm test
passesRelease Notes
Notes: Fixes incorrect foreground color on GTK menubar