Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update mojave-dark-mode-guide.md #15888

Merged
merged 3 commits into from Dec 1, 2018
Merged

docs: update mojave-dark-mode-guide.md #15888

merged 3 commits into from Dec 1, 2018

Conversation

JB1905
Copy link
Contributor

@JB1905 JB1905 commented Nov 29, 2018

Add info about dark mode support in electron-builder

Description of Change

Add info about dark mode support in electron-builder in mojave-dark-mode-guide.md

Release Notes
Notes: Add info about dark mode support in electron-builder in mojave-dark-mode-guide.md

Add info about dark mode support in electron-builder
@JB1905 JB1905 requested a review from a team November 29, 2018 18:14
@welcome
Copy link

welcome bot commented Nov 29, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codebytere
Copy link
Member

@JB1905 it looks like you deleted the issue template, please go back and fill that out. Missing fields will fail CI checks like the release-notescheck.

@ckerr
Copy link
Member

ckerr commented Nov 29, 2018

(FYI cc @MarshallOfSound)

@JB1905 JB1905 changed the title Update mojave-dark-mode-guide.md docs: update mojave-dark-mode-guide.md Nov 29, 2018
@@ -24,8 +24,7 @@ to set the `NSRequiresAquaSystemAppearance` key in your app's `Info.plist` file
</plist>
```

If you are using [`electron-packager` >= 12.2.0](https://github.com/electron-userland/electron-packager) or
[`electron-forge` >= 6](https://github.com/electron-userland/electron-forge) you can set the
If you are using [`electron-packager` >= 12.2.0](https://github.com/electron-userland/electron-packager), [`electron-forge` >= 6](https://github.com/electron-userland/electron-forge) or [`electron-builder` >= 20.37.0](https://github.com/electron-userland/electron-builder) you can set the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the builder reference should be put in a new paragraph beneath this one with its own links to builders option name. Builders option is not the same as forges / packagers.

@MarshallOfSound MarshallOfSound merged commit 1672cff into electron:master Dec 1, 2018
@release-clerk
Copy link

release-clerk bot commented Dec 1, 2018

Release Notes Persisted

Add info about dark mode support in electron-builder in mojave-dark-mode-guide.md

@welcome
Copy link

welcome bot commented Dec 1, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants