New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update mojave-dark-mode-guide.md #15888
Conversation
Add info about dark mode support in electron-builder
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
@JB1905 it looks like you deleted the issue template, please go back and fill that out. Missing fields will fail CI checks like the |
(FYI cc @MarshallOfSound) |
@@ -24,8 +24,7 @@ to set the `NSRequiresAquaSystemAppearance` key in your app's `Info.plist` file | |||
</plist> | |||
``` | |||
|
|||
If you are using [`electron-packager` >= 12.2.0](https://github.com/electron-userland/electron-packager) or | |||
[`electron-forge` >= 6](https://github.com/electron-userland/electron-forge) you can set the | |||
If you are using [`electron-packager` >= 12.2.0](https://github.com/electron-userland/electron-packager), [`electron-forge` >= 6](https://github.com/electron-userland/electron-forge) or [`electron-builder` >= 20.37.0](https://github.com/electron-userland/electron-builder) you can set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the builder reference should be put in a new paragraph beneath this one with its own links to builders option name. Builders option is not the same as forges / packagers.
Release Notes Persisted
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Add info about dark mode support in electron-builder
Description of Change
Add info about dark mode support in electron-builder in
mojave-dark-mode-guide.md
Release Notes
Notes: Add info about dark mode support in electron-builder in mojave-dark-mode-guide.md