fix: correct windowMenu role on MacOS #15930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this technically |
codebytere
changed the title
|
Maybe? i'd say |
|
Hm, I could see the argument each way. Even though the behavior is technically incorrect, if fixing it could potentially cause apps or behavior to change in a non-backward-compat way, I'd argue that it's probably better a |
BinaryMuse
approved these changes
Dec 3, 2018
|
Release Notes Persisted
|
5 tasks
trop-bot
pushed a commit
to trop-bot/electron
that referenced
this pull request
Feb 25, 2019
It was changed in electron#15930
trop-bot
pushed a commit
to trop-bot/electron
that referenced
this pull request
Feb 25, 2019
It was changed in electron#15930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Resolves #15912.
Updates
windowMenuMenuItem role to more accurately reflect the default window menu on MacOS. Also updates the default app to use this role./cc @sindresorhus @BinaryMuse
Checklist
npm testpassesRelease Notes
Notes: correct windowMenu MenuItem role on MacOS