Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register webview in main world when using contextIsolation #16067

Merged
merged 1 commit into from Dec 14, 2018

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Dec 14, 2018

Description of Change

Fix WebView tag not registered in main world when using contextIsolation.

Close #9736.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: Fix <webview> tag not working when using contextIsolation.

@zcbenz zcbenz requested a review from a team December 14, 2018 03:04
@zcbenz
Copy link
Member Author

zcbenz commented Dec 14, 2018

Need to have #16065 merged before backporting to 4-0-x.

@zcbenz zcbenz merged commit 8584c2f into master Dec 14, 2018
@release-clerk
Copy link

release-clerk bot commented Dec 14, 2018

Release Notes Persisted

Fix <webview> tag not working when using contextIsolation.

@zcbenz zcbenz deleted the fix-webview-in-contextisolation branch December 14, 2018 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants