feat: expose app accessibility status api #16119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
approved these changes
Dec 18, 2018
|
@codebytere you had a small bug in the code, passing |
miniak
force-pushed
the
accessibility-check
branch
from
da555eb
to
0b8f8ca
Compare
|
ah ok, i wasn't sure if objc bool literal could be coerced from c++ bools |
BinaryMuse
reviewed
Dec 18, 2018
|
Release Notes Persisted
|
This was referenced Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Resolves #16090.
Exposes an api through System Preferences allowing an app to determine whether or not it's been designated a trusted accessibility client, where that means an app that is allowed to modify the way users interact with their computer.
This API takes a prompt argument; if
falseis passed then the result will be returned silently, and iftrueis passed then a dialog (like the one below) will be shown./cc @miniak @4ndv
Checklist
npm testpassesRelease Notes
Notes: Exposes an API to allow apps to determine their status as a trusted accessibility client.