Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: specify "role" types for "menu-item" #16129

Merged
merged 1 commit into from Dec 19, 2018

Conversation

moshfeu
Copy link
Contributor

@moshfeu moshfeu commented Dec 18, 2018

Description of Change

Specify the types of the role property of MenuItem so it will be generated in the definition file (electron.d.ts) as types but not just string.

Checklist

  • PR description included and (stakeholders cc'd - I don't know who they are)
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app-developers

Release Notes

Notes: MenuItem.role has his own type for preventing mistakes with specify its value.

@moshfeu moshfeu requested a review from a team December 18, 2018 22:57
@welcome
Copy link

welcome bot commented Dec 18, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@jkleinsc jkleinsc merged commit ddc38ed into electron:master Dec 19, 2018
@release-clerk
Copy link

release-clerk bot commented Dec 19, 2018

Release Notes Persisted

MenuItem.role has his own type for preventing mistakes with specify its value.

@welcome
Copy link

welcome bot commented Dec 19, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@moshfeu moshfeu deleted the update-role-types branch December 23, 2018 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants