From 3e0bbc19e30a35048a71d1ec6fbddeab33f1d16e Mon Sep 17 00:00:00 2001 From: Mosh Feu Date: Mon, 24 Dec 2018 09:35:58 +0200 Subject: [PATCH 1/5] Show the code of adding devtools extension --- docs/tutorial/devtools-extension.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/docs/tutorial/devtools-extension.md b/docs/tutorial/devtools-extension.md index d96d272860576..b4e6dd4cab02b 100644 --- a/docs/tutorial/devtools-extension.md +++ b/docs/tutorial/devtools-extension.md @@ -29,7 +29,14 @@ Using the [React Developer Tools][react-devtools] as example: * on macOS it is `~/Library/Application Support/Google/Chrome/Default/Extensions`. 1. Pass the location of the extension to `BrowserWindow.addDevToolsExtension` API, for the React Developer Tools, it is something like: - `~/Library/Application Support/Google/Chrome/Default/Extensions/fmkadmapgofadopljbjfkapdkoienihi/0.15.0_0` + ``` + const { join } = require('path'); + const { homedir } = require('os'); + + BrowserWindow.addDevToolsExtension( + join(homedir(),'/Library/Application\Support/Google/Chrome/Default/Extensions/fmkadmapgofadopljbjfkapdkoienihi/0.15.0_0') + ); + ``` **Note:** The `BrowserWindow.addDevToolsExtension` API cannot be called before the ready event of the app module is emitted. From 38b4e90950d4f2d93f0e46430096c093d1da1671 Mon Sep 17 00:00:00 2001 From: Mosh Feu Date: Mon, 24 Dec 2018 12:58:44 +0200 Subject: [PATCH 2/5] code-language flag --- docs/tutorial/devtools-extension.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tutorial/devtools-extension.md b/docs/tutorial/devtools-extension.md index b4e6dd4cab02b..27ea1b8cad02e 100644 --- a/docs/tutorial/devtools-extension.md +++ b/docs/tutorial/devtools-extension.md @@ -29,7 +29,7 @@ Using the [React Developer Tools][react-devtools] as example: * on macOS it is `~/Library/Application Support/Google/Chrome/Default/Extensions`. 1. Pass the location of the extension to `BrowserWindow.addDevToolsExtension` API, for the React Developer Tools, it is something like: - ``` + ```javascript const { join } = require('path'); const { homedir } = require('os'); From 248a553f8aa7e00b3bfcea9b84bd4002246adbfc Mon Sep 17 00:00:00 2001 From: Mosh Feu Date: Tue, 25 Dec 2018 07:39:46 +0200 Subject: [PATCH 3/5] Remove unnecessary character --- docs/tutorial/devtools-extension.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tutorial/devtools-extension.md b/docs/tutorial/devtools-extension.md index 27ea1b8cad02e..2feb224c0ef0c 100644 --- a/docs/tutorial/devtools-extension.md +++ b/docs/tutorial/devtools-extension.md @@ -34,7 +34,7 @@ Using the [React Developer Tools][react-devtools] as example: const { homedir } = require('os'); BrowserWindow.addDevToolsExtension( - join(homedir(),'/Library/Application\Support/Google/Chrome/Default/Extensions/fmkadmapgofadopljbjfkapdkoienihi/0.15.0_0') + join(homedir(),'/Library/Application Support/Google/Chrome/Default/Extensions/fmkadmapgofadopljbjfkapdkoienihi/0.15.0_0') ); ``` From eb64b6e845b6c40206ec0cf0824ed5fa3466b39a Mon Sep 17 00:00:00 2001 From: Mosh Feu Date: Tue, 8 Jan 2019 14:03:20 +0200 Subject: [PATCH 4/5] Update example https://github.com/electron/electron/pull/16186#pullrequestreview-190180669 --- docs/tutorial/devtools-extension.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/tutorial/devtools-extension.md b/docs/tutorial/devtools-extension.md index 2feb224c0ef0c..e6861d7217811 100644 --- a/docs/tutorial/devtools-extension.md +++ b/docs/tutorial/devtools-extension.md @@ -30,11 +30,11 @@ Using the [React Developer Tools][react-devtools] as example: 1. Pass the location of the extension to `BrowserWindow.addDevToolsExtension` API, for the React Developer Tools, it is something like: ```javascript - const { join } = require('path'); - const { homedir } = require('os'); + const path = require('path'); + const os = require('os'); BrowserWindow.addDevToolsExtension( - join(homedir(),'/Library/Application Support/Google/Chrome/Default/Extensions/fmkadmapgofadopljbjfkapdkoienihi/0.15.0_0') + path.join(os.homedir(),'/Library/Application\Support/Google/Chrome/Default/Extensions/fmkadmapgofadopljbjfkapdkoienihi/0.15.0_0') ); ``` From 4699d8367892fb81faf9cd619f40ccaf5984bb39 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 15 Jan 2019 16:14:07 +0900 Subject: [PATCH 5/5] Format code --- docs/tutorial/devtools-extension.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/tutorial/devtools-extension.md b/docs/tutorial/devtools-extension.md index e6861d7217811..e93ec06fb122f 100644 --- a/docs/tutorial/devtools-extension.md +++ b/docs/tutorial/devtools-extension.md @@ -30,12 +30,12 @@ Using the [React Developer Tools][react-devtools] as example: 1. Pass the location of the extension to `BrowserWindow.addDevToolsExtension` API, for the React Developer Tools, it is something like: ```javascript - const path = require('path'); - const os = require('os'); + const path = require('path') + const os = require('os') BrowserWindow.addDevToolsExtension( - path.join(os.homedir(),'/Library/Application\Support/Google/Chrome/Default/Extensions/fmkadmapgofadopljbjfkapdkoienihi/0.15.0_0') - ); + path.join(os.homedir(), '/Library/Application Support/Google/Chrome/Default/Extensions/fmkadmapgofadopljbjfkapdkoienihi/0.15.0_0') + ) ``` **Note:** The `BrowserWindow.addDevToolsExtension` API cannot be called before the