Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable nodeIntegration / webviewTag by default #16235

Merged
merged 1 commit into from Jan 7, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 2, 2019

Description of Change

The previous default values have been deprecated in Electron 4.0. Follow up to #15045 and #16004.

BREAKING CHANGE

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app-developers

Release Notes

Notes: The default values of nodeIntegration and webviewTag are now false to improve security.

@miniak miniak requested review from a team January 2, 2019 20:05
@miniak miniak force-pushed the miniak/disable-node-integration branch 3 times, most recently from d47d14e to 3977d2f Compare January 2, 2019 21:25
@miniak miniak force-pushed the miniak/disable-node-integration branch from 3977d2f to 0cba8ab Compare January 3, 2019 08:31
@miniak miniak self-assigned this Jan 3, 2019
@miniak miniak force-pushed the miniak/disable-node-integration branch 2 times, most recently from ab85ebc to c3fd1b8 Compare January 3, 2019 16:35
@miniak miniak added the wip ⚒ label Jan 3, 2019
@miniak miniak force-pushed the miniak/disable-node-integration branch 3 times, most recently from c20b5fd to d5a3c98 Compare January 3, 2019 19:58
@miniak miniak requested a review from a team January 3, 2019 19:58
@miniak miniak force-pushed the miniak/disable-node-integration branch from d5a3c98 to 418e63d Compare January 5, 2019 00:49
@miniak miniak removed the wip ⚒ label Jan 5, 2019
@miniak miniak changed the title [wip] chore: make nodeIntegration / webviewTag defaults false chore: make nodeIntegration / webviewTag defaults false Jan 5, 2019
@miniak miniak changed the title chore: make nodeIntegration / webviewTag defaults false chore: disable nodeIntegration / webviewTag by default Jan 7, 2019
SetDefaultBoolIfUndefined(options::kNodeIntegrationInWorker, false);
SetDefaultBoolIfUndefined(options::kWebviewTag, node);
SetDefaultBoolIfUndefined(options::kWebviewTag, false);
SetDefaultBoolIfUndefined(options::kSandbox, false);
SetDefaultBoolIfUndefined(options::kNativeWindowOpen, false);
SetDefaultBoolIfUndefined(options::kContextIsolation, false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This default was also deprecated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarshallOfSound I know, this one will be handled in a separate PR.

@alexeykuzmin alexeykuzmin merged commit fade3eb into master Jan 7, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 7, 2019

Release Notes Persisted

The default values of nodeIntegration and webviewTag are now false to improve security.

akisctx pushed a commit to akisctx/electron that referenced this pull request Jan 22, 2019
deepak1556 pushed a commit to microsoft/vscode that referenced this pull request May 8, 2019
The default values have been flipped for security in
electron/electron#16235
deepak1556 pushed a commit to microsoft/vscode that referenced this pull request May 10, 2019
The default values have been flipped for security in
electron/electron#16235
deepak1556 pushed a commit to microsoft/vscode that referenced this pull request May 16, 2019
The default values have been flipped for security in
electron/electron#16235
deepak1556 pushed a commit to microsoft/vscode that referenced this pull request Jun 4, 2019
The default values have been flipped for security in
electron/electron#16235
deepak1556 pushed a commit to microsoft/vscode that referenced this pull request Jun 4, 2019
The default values have been flipped for security in
electron/electron#16235
deepak1556 added a commit to microsoft/vscode that referenced this pull request Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants