Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional remote APIs filtering #16293

Merged
merged 1 commit into from Jan 8, 2019
Merged

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 7, 2019

Description of Change

Follow up to #15014:

  • remote.getBuiltin() by handling remote-get-builtin
  • remote.getCurrentWindow() by handling remote-get-current-window
  • remote.getCurrentWebContents() by handling remote-get-current-web-contents
  • <webview>.getWebContents() (implemented via remote.getGuestWebContents()) by handling remote-get-guest-web-contents

I can be used to return a proxied or filtered version of the electron APIs.

Checklist

Release Notes

Notes: Allowed filtering of remote.getBuiltin(), remote.getCurrentWindow(), remote.getCurrentWebContents and <webview>.getWebContents().

@miniak miniak self-assigned this Jan 7, 2019
@miniak miniak changed the title feat: add remote.getBuiltin() / remote.getCurrentWindow() / remote.getCurrentWebContents() filtering feat: add additional remote module filtering Jan 7, 2019
@miniak miniak changed the title feat: add additional remote module filtering feat: add additional remote APIs filtering Jan 7, 2019
Copy link
Member

@ppontes ppontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miniak
Copy link
Contributor Author

miniak commented Jan 7, 2019

@MarshallOfSound, @nornagon can you please review?

Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test failures look relevant

@miniak
Copy link
Contributor Author

miniak commented Jan 7, 2019

@nornagon some tests were broken after nodeIntegration was disabled by default. fixed those

lib/browser/rpc-server.js Outdated Show resolved Hide resolved
lib/browser/rpc-server.js Outdated Show resolved Hide resolved
spec/api-app-spec.js Outdated Show resolved Hide resolved
spec/api-app-spec.js Show resolved Hide resolved
@nornagon nornagon merged commit 349a3c2 into master Jan 8, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 8, 2019

Release Notes Persisted

Allow filtering of remote.getBuiltin(), remote.getCurrentWindow(), remote.getCurrentWebContents and <webview>.getWebContents().

@nornagon nornagon deleted the miniak/remote-handlers branch January 8, 2019 22:28
akisctx pushed a commit to akisctx/electron that referenced this pull request Jan 22, 2019
@miniak
Copy link
Contributor Author

miniak commented Feb 1, 2019

/trop run backport-to 4-0-x

@trop
Copy link
Contributor

trop bot commented Feb 1, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "4-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Feb 1, 2019

I was unable to backport this PR to "4-0-x" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants