New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make zoomLevel/zoomFactor sync #16410
Conversation
92326cd
to
6e0b22b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetZoomFactor
and GetZoomLevel
were originally implemented using webFrame apis, hence they had to rely on ipc and had an async api signature. It then got refactored to rely on the browser side ZoomController
. These apis no longer need to be async, its better to deprecate the current signature in favor of that instead of promisification.
707356c
to
cf5d11d
Compare
cf5d11d
to
5562f02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a plan to handle the deprecations of the async signatures ?
a469044
to
d85402a
Compare
Must be merged with: electron/typescript-definitions#119 |
d85402a
to
2133f87
Compare
2133f87
to
5454cd0
Compare
Release Notes Persisted
|
* feat: make zoomLevel/zoomFactor sync * update ts defs dep
Description of Change
Convert
webContents
getZoomLevel
andgetZoomFactor
to be sync methods.cc @ckerr
Checklist
npm test
passesRelease Notes
Notes: Converted
zoomLevel()
andzoomFactor()
forwebContents
and<webview>
to return a promise instead taking a callback.