fix: correctly handle IPC for promise-based methods #16433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
approved these changes
Jan 17, 2019
|
Release Notes Persisted
|
|
I was unable to backport this PR to "3-1-x" cleanly; |
|
I was unable to backport this PR to "4-0-x" cleanly; |
akisctx
pushed a commit
to akisctx/electron
that referenced
this pull request
Jan 22, 2019
codebytere
added a commit
that referenced
this pull request
Jan 31, 2019
6 tasks
codebytere
added a commit
that referenced
this pull request
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Pulling this PR out of #16410, since
zoomLevelandzoomFactorno longer need to be retrieved in an async manner. This PR takes into account async methods that return a promise as separate entities from those that simply take callbacks, and ensures that they are appropriately handled by ipc./cc @MarshallOfSound
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue with promise methods not resolving correctly over ipc in the renderer process.