Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make ipc-message and ipc-message-sync events public #16468

Merged
merged 1 commit into from Jan 22, 2019
Merged

feat: make ipc-message and ipc-message-sync events public #16468

merged 1 commit into from Jan 22, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 20, 2019 •
edited

Description of Change

  • Allows handling IPC messages for particular webContents.
  • Both ipc-message and ipc-message-sync on webContents are refactored to make the arguments easier to handle.

/cc @MarshallOfSound, @nornagon

Checklist

Release Notes

Notes: Added ipc-message and ipc-message-sync events to webContents.

@miniak miniak requested review from a team January 20, 2019 10:38
@miniak miniak changed the title feat: make ipc-message and ipc-message-sync events public feat: make ipc-message and ipc-message-sync events public Jan 20, 2019
@miniak miniak mentioned this pull request Jan 20, 2019
Closed
6 tasks
@miniak miniak self-assigned this Jan 20, 2019
@miniak miniak force-pushed the miniak/ipc-message branch 2 times, most recently from fe38ad6 to e5b6474 Compare January 20, 2019 13:46
MarshallOfSound
MarshallOfSound requested changes Jan 21, 2019
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove all refactors of the internal implementation of IPC. The only things that need to happen this PR

  • Publicly document the events
  • Change the signiture of ipc-message* events to be event, channel, ...args instead of event, [channel, args]

@miniak miniak force-pushed the miniak/ipc-message branch 3 times, most recently from f19fda8 to 6828ed5 Compare January 21, 2019 23:10
@miniak
Copy link
Contributor Author

miniak commented Jan 21, 2019

@MarshallOfSound done

@zcbenz
Copy link
Member

zcbenz commented Jan 22, 2019

The CI is failing on 2 tests:

chromium feature navigator.serviceWorker should register for file scheme - should register for file scheme
chromium feature window.opener is null for main window - is null for main window

They don't seem to be flaky as they are failing on all platforms, though I'm not sure why this change would lead to the failures.

@miniak
Copy link
Contributor Author

miniak commented Jan 22, 2019

@zcbenz fixed

ppontes
ppontes approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@ppontes ppontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@BinaryMuse BinaryMuse merged commit 6cba2c5 into master Jan 22, 2019
@BinaryMuse BinaryMuse deleted the miniak/ipc-message branch January 22, 2019 16:48
@release-clerk
Copy link

release-clerk bot commented Jan 22, 2019

Release Notes Persisted

Added ipc-message and ipc-message-sync events to webContents.

@miniak miniak mentioned this pull request Jan 22, 2019
Merged
3 tasks
@zcbenz zcbenz mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@ppontes ppontes ppontes approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@miniak @zcbenz @alexeykuzmin @MarshallOfSound @ppontes @BinaryMuse