Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: TouchBar API example #16482

Merged
merged 1 commit into from Jan 22, 2019
Merged

Conversation

mattleff
Copy link
Contributor

@mattleff mattleff commented Jan 22, 2019

Description of Change

Corrected TouchBar API example per code:

let { items, escapeItem } = options
This API seems to have changed with #15650.

Checklist

Release Notes

Notes: Improved TouchBar API documentation

@mattleff mattleff requested a review from a team January 22, 2019 00:17
@welcome
Copy link

welcome bot commented Jan 22, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@MarshallOfSound
Copy link
Member

Good catch, thanks 👍

@MarshallOfSound MarshallOfSound merged commit a9ac75c into electron:master Jan 22, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 22, 2019

Release Notes Persisted

Improved TouchBar API documentation

@welcome
Copy link

welcome bot commented Jan 22, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@mattleff mattleff deleted the patch-1 branch January 22, 2019 03:16
akisctx pushed a commit to akisctx/electron that referenced this pull request Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants