fix: correctly destroy spellcheck client #16525

nitsakh · 2019-01-24T07:02:25Z

Backport of #16448.

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation is changed or added
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Notes: Fixed memory leak caused by webFrame.setSpellCheckProvider.

deepak1556 · 2019-01-24T15:14:29Z

Can we re-run the ci build for electron-mas-testing, the test failure is a little concerning. Although this patch does pass on master.

@nitsakh any idea what might cause it to flake ?

nitsakh · 2019-01-24T18:16:01Z

Not sure why that's failing. This change shouldn't have affected the spellcheck implementation.

codebytere · 2019-01-29T23:59:48Z

@deepak1556 the failure passes on rerun, we should be good to go here!

release-clerk · 2019-01-30T00:00:00Z

Release Notes Persisted

Fixed memory leak caused by webFrame.setSpellCheckProvider.

nitsakh added 2 commits January 23, 2019 22:55

fix: Destroy spellcheck client

6cb92bd

Address review comments

f224b27

nitsakh requested a review from a team January 24, 2019 07:02

codebytere added backport This is a backport PR 5-0-x labels Jan 24, 2019

codebytere changed the title ~~Fix spell leak 5 0~~ fix: correctly destroy spellcheck client Jan 24, 2019

codebytere approved these changes Jan 29, 2019

View reviewed changes

codebytere merged commit ae85864 into 5-0-x Jan 29, 2019

codebytere deleted the fix-spell-leak-5-0 branch January 30, 2019 00:00

Provide feedback