fix: Use async save dialog for anchor download attribute (backport: 5-0-x) #16640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
On macOS, the synchronous save dialog does not work properly and breaks in weird ways when the dialog is expanded/collapsed (see electron#14606). This works around the problem for the dialog shown for `<a download=...>` by switching to the asynchronous API. To test this: main.js: ``` const { app, BrowserWindow, session } = require('electron') const path = require('path') function createWindow() { win = new BrowserWindow({ width: 600, height: 600, webPreferences: { nodeIntegration: false, }, }) session.defaultSession.on('will-download', (event, item) => { // Test with and without this commented out. //item.setSavePath(path.join(app.getPath('desktop'), 'test-download.txt')) }) win.loadURL(`file://${__dirname}/test.html`) } app.on('ready', createWindow) ``` test.html: ``` <html> <head> <meta http-equiv="Content-Security-Policy" content="default-src 'self'; style-src 'self' 'unsafe-inline'; script-src 'self' 'unsafe-inline'; img-src 'self' data:"> </head> <body> <a href="data:application/xml;charset=utf-8,foo" download="download.txt">Save</a> </body> ```
zcbenz
approved these changes
Jan 31, 2019
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #16612
See that PR for details.
Notes: Fix broken save dialog on macOS for
<a>downloads