Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify contentTracing recording APIs #16642

Merged
merged 1 commit into from Feb 1, 2019
Merged

Conversation

codebytere
Copy link
Member

Description of Change

Backport of #16584.

Checklist

Release Notes

Notes: Converted contentTracing.startRecording() and contentTracing.stopRecording() to return a promise instead taking a callback.

@codebytere codebytere added backport This is a backport PR 5-0-x labels Jan 31, 2019
@codebytere codebytere requested review from a team January 31, 2019 03:02
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@codebytere
Copy link
Member Author

This shouldn't be merged until it's rebased on #16643

* feat: promisify contentTracing.startRecording()

* feat: promisify contentTracing.stopRecording()

* test: convert specs for new promisified apis

* chore: deprecate and ensure legacy tests work
@release-clerk
Copy link

release-clerk bot commented Feb 1, 2019

Release Notes Persisted

Converted contentTracing.startRecording() and contentTracing.stopRecording() to return a promise instead taking a callback.

@codebytere codebytere deleted the recording-bp branch February 1, 2019 20:31
Copy link

@alejagapatrick alejagapatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants