Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add window removeMenu() method (backport: 5-0-x) #16657

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 31, 2019

Backport of #16570

See that PR for details.

Notes: Added win.removeMenu() to remove application menus instead of using win.setMenu(null).

@trop trop bot requested review from a team January 31, 2019 18:58
@trop trop bot mentioned this pull request Jan 31, 2019
6 tasks
@trop trop bot added 5-0-x backport This is a backport PR labels Jan 31, 2019
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold for Kickoff vote!

Copy link
Contributor

@groundwater groundwater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 in weekly kickoff

@@ -659,6 +659,13 @@ void TopLevelWindow::SetMenu(v8::Isolate* isolate, v8::Local<v8::Value> value) {
}
}

void TopLevelWindow::RemoveMenu() {
mate::Handle<Menu> menu;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this variable ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove in follow-up

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codebytere codebytere merged commit 26e0a7d into electron:5-0-x Feb 4, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 4, 2019

Release Notes Persisted

Added win.removeMenu() to remove application menus instead of using win.setMenu(null).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants