Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support capslock and numlock as accelerators (backport: 5-0-x) #16725

Merged
merged 2 commits into from Feb 11, 2019
Merged

feat: support capslock and numlock as accelerators (backport: 5-0-x) #16725

merged 2 commits into from Feb 11, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 4, 2019

Backport of #16719

See that PR for details.

Notes: Add caps lock and numlock as keyboard accelerator modifiers.

@trop trop bot requested review from a team February 4, 2019 23:55
@trop trop bot mentioned this pull request Feb 4, 2019
Merged
4 tasks
@trop trop bot added 5-0-x backport This is a backport PR labels Feb 4, 2019
codebytere
codebytere previously requested changes Feb 4, 2019
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold for Kickoff Vote

BinaryMuse
BinaryMuse approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@BinaryMuse BinaryMuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in kickoff ✨

groundwater
groundwater approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@groundwater groundwater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from kickoff vote

@codebytere codebytere merged commit 30cc82d into electron:5-0-x Feb 11, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 11, 2019

Release Notes Persisted

Add caps lock and numlock as keyboard accelerator modifiers.

@erickzhao erickzhao mentioned this pull request Jan 29, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinaryMuse BinaryMuse BinaryMuse approved these changes

@groundwater groundwater groundwater approved these changes

@codebytere codebytere codebytere left review comments

Assignees
No one assigned
Labels
5-0-x backport/requested 🗳 backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BinaryMuse @groundwater @codebytere @MarshallOfSound