Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display empty menu item for non-visible submenus (backport: 5-0-x) #16848

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 8, 2019

Backport of #16832

See that PR for details.

Notes: Fixed issue whereby a user was not well informed when interacting with a menu submenu that did not have any visible MenuItems.

@trop trop bot requested a review from a team February 8, 2019 21:19
@trop trop bot added 5-0-x backport This is a backport PR labels Feb 8, 2019
@codebytere codebytere merged commit 91a67e4 into electron:5-0-x Feb 8, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 8, 2019

Release Notes Persisted

Fixed issue whereby a user was not well informed when interacting with a menu submenu that did not have any visible MenuItems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant