Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak when using webFrame and spell checker (backport: 5-0-x) #16851

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 8, 2019

Backport of #16770

See that PR for details.

Notes: Fix memory leak when using webFrame and spell checker.

When reloading a page without restarting renderer process (for example
sandbox mode), the blink::WebFrame is not destroyed, but api::WebFrame
is always recreated for the new page context. This leaves a leak of
api::WebFrame.
@trop trop bot requested a review from a team February 8, 2019 21:38
@trop trop bot added 5-0-x backport This is a backport PR labels Feb 8, 2019
@MarshallOfSound MarshallOfSound merged commit 8b5f26a into electron:5-0-x Feb 8, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 8, 2019

Release Notes Persisted

Fix memory leak when using webFrame and spell checker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants