From 45ff7c0c6af948ec6ebc58f2fa533a237bd2fb45 Mon Sep 17 00:00:00 2001 From: rhysd Date: Tue, 19 Feb 2019 20:15:45 +0900 Subject: [PATCH 1/3] docs: Fixed hook methods of WebRequest accepts null as listener --- docs/api/web-request.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/api/web-request.md b/docs/api/web-request.md index 920ba8758da04..7fd3909dcc58f 100644 --- a/docs/api/web-request.md +++ b/docs/api/web-request.md @@ -45,7 +45,7 @@ The following methods are available on instances of `WebRequest`: * `filter` Object (optional) * `urls` String[] - Array of URL patterns that will be used to filter out the requests that do not match the URL patterns. -* `listener` Function +* `listener` Function | null * `details` Object * `id` Integer * `url` String @@ -72,7 +72,7 @@ The `callback` has to be called with an `response` object. * `filter` Object (optional) * `urls` String[] - Array of URL patterns that will be used to filter out the requests that do not match the URL patterns. -* `listener` Function +* `listener` Function | null * `details` Object * `id` Integer * `url` String @@ -98,7 +98,7 @@ The `callback` has to be called with an `response` object. * `filter` Object (optional) * `urls` String[] - Array of URL patterns that will be used to filter out the requests that do not match the URL patterns. -* `listener` Function +* `listener` Function | null * `details` Object * `id` Integer * `url` String @@ -117,7 +117,7 @@ response are visible by the time this listener is fired. * `filter` Object (optional) * `urls` String[] - Array of URL patterns that will be used to filter out the requests that do not match the URL patterns. -* `listener` Function +* `listener` Function | null * `details` Object * `id` Integer * `url` String @@ -147,7 +147,7 @@ The `callback` has to be called with an `response` object. * `filter` Object (optional) * `urls` String[] - Array of URL patterns that will be used to filter out the requests that do not match the URL patterns. -* `listener` Function +* `listener` Function | null * `details` Object * `id` Integer * `url` String @@ -170,7 +170,7 @@ and response headers are available. * `filter` Object (optional) * `urls` String[] - Array of URL patterns that will be used to filter out the requests that do not match the URL patterns. -* `listener` Function +* `listener` Function | null * `details` Object * `id` Integer * `url` String @@ -193,7 +193,7 @@ redirect is about to occur. * `filter` Object (optional) * `urls` String[] - Array of URL patterns that will be used to filter out the requests that do not match the URL patterns. -* `listener` Function +* `listener` Function | null * `details` Object * `id` Integer * `url` String @@ -215,7 +215,7 @@ completed. * `filter` Object (optional) * `urls` String[] - Array of URL patterns that will be used to filter out the requests that do not match the URL patterns. -* `listener` Function +* `listener` Function | null * `details` Object * `id` Integer * `url` String From dae7a09314e012ab0f079eca1c040c8232deaa35 Mon Sep 17 00:00:00 2001 From: rhysd Date: Tue, 19 Feb 2019 20:17:24 +0900 Subject: [PATCH 2/3] docs: Added missing `referrer` property in OnBeforeRequestDetails --- docs/api/web-request.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/api/web-request.md b/docs/api/web-request.md index 7fd3909dcc58f..6c458d15a6b17 100644 --- a/docs/api/web-request.md +++ b/docs/api/web-request.md @@ -52,6 +52,7 @@ The following methods are available on instances of `WebRequest`: * `method` String * `webContentsId` Integer (optional) * `resourceType` String + * `referrer` String * `timestamp` Double * `uploadData` [UploadData[]](structures/upload-data.md) * `callback` Function From 67a9b87c52108dec91cd37673f1d242f12fac93d Mon Sep 17 00:00:00 2001 From: rhysd Date: Thu, 28 Feb 2019 11:55:41 +0900 Subject: [PATCH 3/3] docs: Add `referrer` to each webRequest responses --- docs/api/web-request.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/api/web-request.md b/docs/api/web-request.md index 6c458d15a6b17..d255bf43ed384 100644 --- a/docs/api/web-request.md +++ b/docs/api/web-request.md @@ -80,6 +80,7 @@ The `callback` has to be called with an `response` object. * `method` String * `webContentsId` Integer (optional) * `resourceType` String + * `referrer` String * `timestamp` Double * `requestHeaders` Object * `callback` Function @@ -106,6 +107,7 @@ The `callback` has to be called with an `response` object. * `method` String * `webContentsId` Integer (optional) * `resourceType` String + * `referrer` String * `timestamp` Double * `requestHeaders` Object @@ -125,6 +127,7 @@ response are visible by the time this listener is fired. * `method` String * `webContentsId` Integer (optional) * `resourceType` String + * `referrer` String * `timestamp` Double * `statusLine` String * `statusCode` Integer @@ -155,6 +158,7 @@ The `callback` has to be called with an `response` object. * `method` String * `webContentsId` Integer (optional) * `resourceType` String + * `referrer` String * `timestamp` Double * `responseHeaders` Object * `fromCache` Boolean - Indicates whether the response was fetched from disk @@ -178,6 +182,7 @@ and response headers are available. * `method` String * `webContentsId` Integer (optional) * `resourceType` String + * `referrer` String * `timestamp` Double * `redirectURL` String * `statusCode` Integer @@ -223,6 +228,7 @@ completed. * `method` String * `webContentsId` Integer (optional) * `resourceType` String + * `referrer` String * `timestamp` Double * `fromCache` Boolean * `error` String - The error description.