Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove label/image from segment if they are mutated to null #17334

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 11, 2019

Backport of #17323

See that PR for details.

Notes: TouchBarSegmentedControl instances now correctly update when you update the segments array and remove label or image dynamically.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 11, 2019
@trop trop bot added 5-0-x backport This is a backport PR labels Mar 11, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 11, 2019
@codebytere codebytere changed the title fix: remove label/image from segment if they are mutated to null (backport: 5-0-x) fix: remove label/image from segment if they are mutated to null Mar 11, 2019
@MarshallOfSound MarshallOfSound merged commit 6a93200 into electron:5-0-x Mar 12, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 12, 2019

Release Notes Persisted

TouchBarSegmentedControl instances now correctly update when you update the segments array and remove label or image dynamically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants