Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check the result when calling js function (backport: 5-0-x) #17481

Merged
merged 2 commits into from Mar 20, 2019
Merged

fix: check the result when calling js function (backport: 5-0-x) #17481

merged 2 commits into from Mar 20, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 20, 2019

Backport of #17443

See that PR for details.

Notes: Fix crash when passing callbacks which return undefined to some APIs.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 20, 2019
@trop trop bot mentioned this pull request Mar 20, 2019
Merged
5 tasks
@trop trop bot added 5-0-x backport This is a backport PR labels Mar 20, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 20, 2019
@MarshallOfSound MarshallOfSound merged commit 821b88e into electron:5-0-x Mar 20, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 20, 2019

Release Notes Persisted

Fix crash when passing callbacks which return undefined to some APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @MarshallOfSound @zcbenz