From 60d88f587b9f9caadc09c99c0721c0a71d07b1b0 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Tue, 19 Mar 2019 12:59:28 -0700 Subject: [PATCH] fix: take foreground visibility into account for isVisible on macOS --- atom/browser/native_window_mac.mm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/atom/browser/native_window_mac.mm b/atom/browser/native_window_mac.mm index 81f039dbcb2ba..5fe1e317fec6f 100644 --- a/atom/browser/native_window_mac.mm +++ b/atom/browser/native_window_mac.mm @@ -576,7 +576,12 @@ void ViewDidMoveToSuperview(NSView* self, SEL _cmd) { } bool NativeWindowMac::IsVisible() { - return [window_ isVisible]; + bool occluded = [window_ occlusionState] == NSWindowOcclusionStateVisible; + + // For a window to be visible, it must be visible to the user in the + // foreground of the app, which means that it should not be minimized or + // occluded + return [window_ isVisible] && !occluded && !IsMinimized(); } bool NativeWindowMac::IsEnabled() {