Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use file path as key for safeDialogs on filesystem (backport: 5-0-x) #17579

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 27, 2019

Backport of #17546

See that PR for details.

Notes: The safeDialogs webPreferences option now actually works on file:// URLs

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 27, 2019
@trop trop bot added 5-0-x backport This is a backport PR labels Mar 27, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 27, 2019
@MarshallOfSound MarshallOfSound merged commit 0e5d181 into electron:5-0-x Mar 27, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 27, 2019

Release Notes Persisted

The safeDialogs webPreferences option now actually works on file:// URLs

@jkleinsc jkleinsc mentioned this pull request Apr 15, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants