feat: enable picture-in-picture mode for video tags

[brenca]

Description of Change

This PR enables the picture-in-picture mode already available in chrome. This is partly a feat:, partly a fix: - without these changes, the DOM reports that PiP mode is available, but no actual window is created for it, and the DOM APIs return a 0x0 phantom PiP window. With these changes if PiP is disabled with the build flag, the DOM APIs correctly report that support for this feature is unavailable.

The added //chrome dependencies are self contained, but there are a couple of extra icons baked into the code when this feature is enabled. I'm happy to explore ways to only include the necessary icons, but we might we might end up with two folders with a small BUILD.gn in each that way, and I thought the easier maintainability/readability vs small size increase was worth it.

Resolves #17369 and #11582.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Added support for picture-in-picture mode for video elements.

[MarshallOfSound]

Is there anyway we can pull some compiler/ninja voodoo to make this work without a patch

cc @nornagon @deepak1556

[nornagon]

Perhaps we could consider refactoring upstream to make these resources more self-contained?

[MarshallOfSound]

Rebased it and tested locally, approving and requesting a 6-0-x backport as without it requesting a PiP view crashes

[deepak1556]

requesting a 6-0-x backport as without it requesting a PiP view crashes

For 6-0-x I would suggest disabling PIP web apis through the embedder hooks https://groups.google.com/a/chromium.org/d/msg/embedder-dev/A4zqjsmibXc/Osy_LLZ0DwAJ. I don't see the reason to ship this feature.

[MarshallOfSound]

@deepak1556 I want to do that for 5-0-x (disable it) but I'd like to make it possible to use this in 6-0-x

[deepak1556]

LGTM, Can you fix the conflicts.

[ckerr]

@brenca ping, can you fix the conflicts

[mohamedghan]

guys, i'm having a bad time trying to add pip in my project. i'm using electron 6.x.x beta15

[Ajeey]

Guys, any updates on this? Would love to see this ported to Electron!

[release-clerk]

Release Notes Persisted

Added support for picture-in-picture mode for video elements.

[codebytere]

/trop run backport-to 7-0-x

[trop]

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "7-0-x" here we go! :D

[trop]

I was unable to backport this PR to "7-0-x" cleanly;
you will need to perform this backport manually.

[trop]

A maintainer has manually backported this PR to "7-0-x", please check out #19914

[alirezavalizade]

I updated to electron v7, but it doesn't work correctly. Actually it has the feature on video tag controls but when you click on it, it doesn't show anything, I only see something like this.

@brenca @MarshallOfSound @zcbenz

[alectrocute]

Same issue here a few months after @alirezavalizade's comment above. This would be a really nice feature to have.