Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: mojofy autofill renderer->browser #18760

Merged
merged 5 commits into from Aug 19, 2019
Merged

Conversation

brenca
Copy link
Contributor

@brenca brenca commented Jun 12, 2019

Description of Change

This is a followup PR for #18723, mojofying the renderer->browser calls similarly to how it's done in chromium, as per discussion with @nornagon.

Checklist

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jun 12, 2019
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lint warnings need to be addressed.

atom/browser/atom_autofill_driver.cc Outdated Show resolved Hide resolved
atom/browser/atom_autofill_driver.cc Outdated Show resolved Hide resolved
atom/browser/atom_autofill_driver_factory.h Outdated Show resolved Hide resolved
atom/browser/atom_autofill_driver_factory.h Outdated Show resolved Hide resolved
atom/browser/atom_autofill_driver_factory.cc Outdated Show resolved Hide resolved
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codebytere codebytere merged commit b33558d into master Aug 19, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 19, 2019

Release Notes Persisted

no-notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants