New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: mojofy autofill renderer->browser #18760
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
PR opened in the last 24 hours
and removed
new-pr 🌱
PR opened in the last 24 hours
labels
Jun 12, 2019
zcbenz
requested changes
Jun 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are lint warnings need to be addressed.
brenca
force-pushed
the
brenca/autofill-4
branch
from
August 11, 2019 00:06
ac1b716
to
6f79ba3
Compare
deepak1556
requested changes
Aug 12, 2019
brenca
force-pushed
the
brenca/autofill-4
branch
from
August 13, 2019 23:25
3d022ee
to
a79b94d
Compare
zcbenz
approved these changes
Aug 15, 2019
deepak1556
approved these changes
Aug 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Release Notes Persisted
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is a followup PR for #18723, mojofying the
renderer
->browser
calls similarly to how it's done inchromium
, as per discussion with @nornagon.Checklist
npm test
passesRelease Notes
Notes: no-notes