From 934cf108f63901b5cf2fe704b2cecbc6a35360cf Mon Sep 17 00:00:00 2001 From: Milan Burda Date: Sat, 15 Jun 2019 15:13:27 +0200 Subject: [PATCH] fix: Uncaught TypeError: Cannot set property 'innerText' of null in default-app --- default_app/renderer.js | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/default_app/renderer.js b/default_app/renderer.js index b971f9fb16e6f..3f58fe95d3eeb 100644 --- a/default_app/renderer.js +++ b/default_app/renderer.js @@ -26,11 +26,18 @@ function initialize () { link.addEventListener('auxclick', openLinkExternally) } - document.querySelector('.electron-version').innerText = `Electron v${process.versions.electron}` - document.querySelector('.chrome-version').innerText = `Chromium v${process.versions.chrome}` - document.querySelector('.node-version').innerText = `Node v${process.versions.node}` - document.querySelector('.v8-version').innerText = `v8 v${process.versions.v8}` - document.querySelector('.command-example').innerText = `${electronPath} path-to-app` + function replaceText (selector, text) { + const element = document.querySelector(selector) + if (element) { + element.innerText = text + } + } + + replaceText('.electron-version', `Electron v${process.versions.electron}`) + replaceText('.chrome-version', `Chromium v${process.versions.chrome}`) + replaceText('.node-version', `Node v${process.versions.node}`) + replaceText('.v8-version', `v8 v${process.versions.v8}`) + replaceText('.command-example', `${electronPath} path-to-app`) function getOcticonSvg (name) { const octiconPath = path.resolve(__dirname, 'node_modules', 'octicons', 'build', 'svg', `${name}.svg`)