New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add about panel customization on Windows #19420
Conversation
4fbbc47
to
d5fbbec
Compare
@erickzhao this is blocked on #19460, right? |
@codebytere yep! I was waiting for that one to get merged to avoid having to re-implement all the business logic available in |
63ae694
to
49ad7d5
Compare
65cd83a
to
752cddb
Compare
Update: added default values for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm & works for me.
Are you aware that the dialog's title will be derived from app.name
?
|
Release Notes Persisted
|
Description of Change
Closes #15591. Adds support for
showAboutPanel()
andsetAboutPanelOptions()
on Windows.Windows doesn't have a native About dialog. This PR reuses the
electron::ShowMessageBox
function to generate a dialog with the About Panel information as a string message.Notes:
applicationName
andapplicationVersion
provided by/src/base/file_version_info.h
.NativeImage
API does.Fields added (all optional):
applicationName
: stringapplicationVersion
: stringcopyright
: stringcredits
: stringiconPath
: stringcc @codebytere @ckerr @sindresorhus
Example
Additional Reading
Microsoft UX Guidelines for Dialog Boxes: https://docs.microsoft.com/en-us/windows/win32/uxguide/win-dialog-box
Relevant bits:
Checklist
npm test
passesRelease Notes
Notes: Added about panel customization on Windows.