feat: implement will-move event on macOS
#19641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
erickzhao
force-pushed
the
intern/will-move-mac
branch
from
3eeff5d
to
2f22e88
Compare
erickzhao
changed the title
will-move event on macOSwill-move event on macOS
codebytere
approved these changes
Aug 14, 2019
miniak
reviewed
Aug 15, 2019
miniak
approved these changes
Aug 20, 2019
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #19613.
Implements the
will-moveevent forBrowserWindowon macOS. However, due to limitations in AppKit, I have yet to find a solution that will properly implementevent.preventDefault().Checklist
npm testpassesRelease Notes
Notes: Implemented 'will-move' event on BrowserWindow on macOS.