Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dontAddToRecent to Windows showOpenDialog #19669

Merged
merged 1 commit into from Aug 13, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Aug 7, 2019

Description of Change

Adds a dontAddToRecent property to the properties object in showOpenDialog and showOpenDialogSync parameters.

This means that items being opened will not be added to the recent documents list.

cc @deermichel @brenca @miniak

Checklist

Release Notes

Notes: Added the ability to prevent documents from being added to recent documents on Windows in open dialogs.

@codebytere codebytere added platform/windows semver/minor backwards-compatible functionality labels Aug 7, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 7, 2019
@codebytere codebytere changed the title feat: add dontAddToRecent to windows showOpenDialog feat: add dontAddToRecent to Windows showOpenDialog Aug 7, 2019
@deermichel
Copy link
Contributor

cc @erickzhao, I guess currently nothing will be added at all 🙈

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 8, 2019
@deermichel
Copy link
Contributor

Hmm yeah sry, just as expected no item shows up on our machine at all. Maybe we need to package a whole application for it. However, your code lgtm - in theory it should work.

@codebytere codebytere merged commit b579832 into master Aug 13, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 13, 2019

Release Notes Persisted

Added the ability to prevent documents from being added to recent documents on Windows in open dialogs.

@codebytere codebytere deleted the dont-add-to-recent branch August 13, 2019 15:48
@TonnyLand
Copy link

electron.openDialog('showOpenDialogSync', dialogConfig);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/windows semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants