feat: macOS removal fallback when moveItemToTrash fails #19700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs #4974.
Some macOS volumes may not support a Trash folder or it may be disabled, so these methods will report failure by returning NO or
nil
and anNSError
withNSFeatureUnsupportedError
.This enables consumers to handle this by optionally passing a boolean
deleteOnFail
value to indicate whether or not the item should be unilaterally deleted if theNSFileManager
fails to executetrashItemAtURL
.cc @miniak @ckerr @MarshallOfSound
Checklist
npm test
passesRelease Notes
Notes: Enable macOS users to fallback to item removal when when
shell.moveItemToTrash
fails.