From 9b28ff9c1d2e71309df40b6074fb988a94be714c Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Tue, 6 Aug 2019 09:36:26 -0700 Subject: [PATCH 1/2] remove cause of issue --- atom/browser/ui/views/menu_bar.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/atom/browser/ui/views/menu_bar.cc b/atom/browser/ui/views/menu_bar.cc index 985a41408dc4c..12f999d5f6243 100644 --- a/atom/browser/ui/views/menu_bar.cc +++ b/atom/browser/ui/views/menu_bar.cc @@ -275,8 +275,8 @@ void MenuBar::OnMenuButtonClicked(views::Button* source, return; } - GetFocusManager()->SetFocusedViewWithReason( - source, views::FocusManager::kReasonFocusTraversal); + // GetFocusManager()->SetFocusedViewWithReason( + // source, views::FocusManager::kReasonFocusTraversal); // Deleted in MenuDelegate::OnMenuClosed MenuDelegate* menu_delegate = new MenuDelegate(this); From 270563b18bc69658b56411992c285ac4e13382c6 Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Wed, 7 Aug 2019 13:13:02 -0700 Subject: [PATCH 2/2] remove comment --- atom/browser/ui/views/menu_bar.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/atom/browser/ui/views/menu_bar.cc b/atom/browser/ui/views/menu_bar.cc index 12f999d5f6243..e55b9e694cb99 100644 --- a/atom/browser/ui/views/menu_bar.cc +++ b/atom/browser/ui/views/menu_bar.cc @@ -275,9 +275,6 @@ void MenuBar::OnMenuButtonClicked(views::Button* source, return; } - // GetFocusManager()->SetFocusedViewWithReason( - // source, views::FocusManager::kReasonFocusTraversal); - // Deleted in MenuDelegate::OnMenuClosed MenuDelegate* menu_delegate = new MenuDelegate(this); menu_delegate->RunMenu(menu_model_->GetSubmenuModelAt(id), source,