Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't handle browser messages before document element is created #19718

Merged
merged 3 commits into from Aug 12, 2019
Merged

fix: don't handle browser messages before document element is created #19718

merged 3 commits into from Aug 12, 2019

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Aug 12, 2019

Description of Change

Close #19368.

This test was introduced by #1044 but then lost when migrating IPC module to mojo. This PR adds the fix back.

Checklist

Release Notes

Notes: Fix async Node APIs not working after received IPC message.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 12, 2019
@zcbenz
fix: bind ElectronApiServiceImpl later
6107735 
DidCreateDocumentElement is called before the ElectronApiServiceImpl
gets bound.
@zcbenz
chore: add comment
34a147e
@zcbenz zcbenz marked this pull request as ready for review August 12, 2019 13:51
@zcbenz zcbenz mentioned this pull request Aug 12, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Aug 12, 2019

A maintainer has manually backported this PR to "6-0-x", please check out #19719

@trop trop bot added the in-flight/6-0-x label Aug 12, 2019
MarshallOfSound
MarshallOfSound approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fluent in mojo but from a purely cpp standing this looks like what we want to be doing and the test case proves it 👍

@MarshallOfSound MarshallOfSound added the fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases label Aug 12, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 12, 2019
deepak1556
deepak1556 approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the mojo changes.

@MarshallOfSound MarshallOfSound merged commit 04dbd5c into master Aug 12, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 12, 2019

Release Notes Persisted

Fix async Node APIs not working after received IPC message.

@MarshallOfSound MarshallOfSound deleted the fix-ipc-node-block branch August 12, 2019 17:38
@trop trop bot mentioned this pull request Aug 12, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Aug 12, 2019

I have automatically backported this PR to "7-0-x", please check out #19722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sending IPC messages to renderers interferes with node http module on windows
4 participants
@zcbenz @deepak1556 @MarshallOfSound @ckerr